Thanks, @Guillaumecoi. In this repo, we exposed ~/.config/hyde/config.toml.

https://github.com/HyDE-Project/HyDE/blob/ec19995601392c6660a5cf64d56f6b8b86eec0b5/Configs/.local/share/hyde/config.toml#L129C1-L131C1
example:

[waybar.weather]
loc= true

As bash do not have an ability to parse a toml file, we have an intermediary script that watches the ~/.config/hyde/config.toml for changes. Once changed, it will generate the state file ~/.local/state/hyde/config .

So I would suggest renaming the variables with WEATHER_ prefixes.

    WEATHER_TEMP_UNIT : c or f (default: c)
    WEATHER_TIME_FORMAT: 12h or 24h (default: 12h)
    WEATHER_WINDSPEED_UNIT: km/h or mph (default: Km/h)
    WEATHER_SHOW_ICON: True or False (default: True)
    WEATHER_SHOW_LOCATION: True or False (default: False)
    WEATHER_SHOW_TODAY_DETAILS: True or False (default: True)
    WEATHER_FORECAST_DAYS: 0,1,2,3 (default: 3)

For this one let's suport 2 variables for now, and will deprecate soon.

WAYBAR_WEATHER_LOC: Placename (default: '', based on IP location)
WEATHER_LOC: Placename (default: '', based on IP location)

This way the config.toml interface will have

[weather]
temperature_unit=c
time_format=
windspeed_unit=
show_icon=
show_location=
show_today=
forecast_days=

Thank you for your explanation since I did not get how the .toml file worked. I really like this solution to handle env variables, it is very clean.

• I changed the variable names in the Python script and tested it by setting the variables in ~/.config/hyde/config.toml.

• I also set the default variables in ~.local/share/hyde/config.toml. So it is more clear how to use them.

I still have some questions:

• "For this one let's support 2 variables for now, and will deprecate soon." My Script does not read the variable WAYBAR_WEATHER_LOC anymore and that is why I deleted it. Is it best to avoid this so people don't lose there loc setting upon updating? If so wouldn't it be better to place all variables under: [waybar.weather] so that I dont have to check 2 variables?

• Is it correct that the variables in ~/.config/hyde/config.toml are not used but are more like a template to show how you can use ~/.config/hyde/config.toml. I think from taking a look at the scripts it does not use these values but it uses the default values in the script which are identical to those in ~/.config/hyde/config.toml

@Guillaumecoi

1. TOML File - This is for users main interface
2. Translator - Intermediary script to translate the TOML file into env variables
3. Env variables - These are variables for bash/shell scripts to use.

As for ~/.local/share/hyde/config.toml it is not used for anything at all. As we don't have a wiki yet therefore I added this file for reference only.

I hope this is pretty clear now.

We knew that python has a TOML lib but for now I want to unify the parsers in a single module so I want this MR to use the environment variable for now.

If so wouldn't it be better to place all variables under: [waybar.weather] so that I dont have to check 2 variables?

Let's break it. I guess only one user is using the feature as of the moment, I'll try to find that specific issue.
after all, weather.py can be used apart from being a waybar module.
Therefore, use :

[weather]
foo=bar

So now I need to change the WEATHER_LOC var defined in ~/.config/hyde/config.toml from [waybar.weather] to [weather] or weather is only used for the specifications on API data fetching and display and LOC var still needs to be defined inside waybar.weather configs?

Let's just unify it under [weather].